Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building UBI9 base container image #676

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

terrytangyuan
Copy link
Contributor

This adds support for UBI9 (Red Hat Universal Base Image 9). Tested registry.access.redhat.com/ubi9/ubi-minimal:9.5.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 21, 2024
@terrytangyuan
Copy link
Contributor Author

@ashwinb Let me know what you think. This is a temporary hack to get things going on our end. We can probably follow-up later to have a better approach.

@raghotham
Copy link
Contributor

@terrytangyuan what would a less hacky solution look like?

@terrytangyuan
Copy link
Contributor Author

@terrytangyuan what would a less hacky solution look like?

@raghotham A more customizable build_container.sh, e.g. allows users to write installation commands for the dependencies besides base image up until llama-stack/models/client installation.

@terrytangyuan
Copy link
Contributor Author

Since users are allowed to change the base image, it's likely that they'd need to change installation instructions for certain dependencies.

@raghotham raghotham added this to the v0.1 milestone Jan 10, 2025
Copy link
Contributor

@hardikjshah hardikjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved !

@hardikjshah hardikjshah merged commit e45592e into meta-llama:main Jan 13, 2025
2 checks passed
@terrytangyuan terrytangyuan deleted the support-ubi branch January 13, 2025 23:32
ashwinb pushed a commit that referenced this pull request Jan 14, 2025
This was missed during a rebase in
#676.

Fixed the following error:
```
Error: crun: executable file `python` not found in $PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found
++ error_handler 88
++ echo 'Error occurred in script at line: 88'
Error occurred in script at line: 88
```

cc @hardikjshah

Signed-off-by: Yuan Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants